wernerdv commented on code in PR #18937: URL: https://github.com/apache/kafka/pull/18937#discussion_r2019968079
########## metadata/src/main/java/org/apache/kafka/metadata/util/SnapshotFileReader.java: ########## @@ -208,8 +208,4 @@ public void close() throws Exception { beginShutdown("closing"); queue.close(); } - - public CompletableFuture<Void> caughtUpFuture() { Review Comment: The commit [0b4e9a](https://github.com/apache/kafka/commit/0b4e9afee2ace7edf6ff8690e070100b98627836#diff-9d62585f89bdb5cc9f1a714f64d7901b9950161326605c0b2124413b3015cbb5L291) removed a commented-out line `//snapshotFileReader.caughtUpFuture().get();`. It seems that does not need to use this method in MetadataShell. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org