ijuma commented on code in PR #19316:
URL: https://github.com/apache/kafka/pull/19316#discussion_r2022835628


##########
core/src/main/scala/kafka/server/RemoteLeaderEndPoint.scala:
##########
@@ -203,7 +203,7 @@ class RemoteLeaderEndPoint(logPrefix: String,
       None
     } else {
       val metadataVersion = metadataVersionSupplier()
-      val version: Short = if (metadataVersion.fetchRequestVersion >= 13 && 
!fetchData.canUseTopicIds) {
+      val version: Short = if (!fetchData.canUseTopicIds) {

Review Comment:
   Yes, I looked into that, but it's a larger change since some of the code is 
shared and topic ids are optional in the shared code. I think we can file a 
JIRA ticket to make this change via a separate PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to