squah-confluent commented on code in PR #19333:
URL: https://github.com/apache/kafka/pull/19333#discussion_r2023370790
##########
coordinator-common/src/test/java/org/apache/kafka/coordinator/common/runtime/CoordinatorRuntimeTest.java:
##########
@@ -649,42 +649,37 @@ public void
testScheduleUnloadingWithDeferredEventExceptions() throws ExecutionE
runtime.scheduleLoadOperation(TP, 10);
CoordinatorRuntime<MockCoordinatorShard, String>.CoordinatorContext
ctx = runtime.contextOrThrow(TP);
- // Get the max batch size.
Review Comment:
I put all three cases in the same test.
Previously, write #2 existed to test the exception handling (it would not be
completed if there was none) and write #3 triggered a flush. Write #2 is
unnecessary in the unload case and the flush is now triggered by the
transaction completion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
