mimaison commented on code in PR #19064:
URL: https://github.com/apache/kafka/pull/19064#discussion_r2027131524
##########
core/src/main/scala/kafka/server/ReplicaManager.scala:
##########
@@ -2587,11 +2587,11 @@ class ReplicaManager(val config: KafkaConfig,
new ReplicaAlterLogDirsManager(config, this, quotaManager,
brokerTopicStats, directoryEventHandler)
}
- private def createReplicaSelector(): Option[ReplicaSelector] = {
+ private def createReplicaSelector(metrics: Metrics):
Option[Plugin[ReplicaSelector]] = {
config.replicaSelectorClassName.map { className =>
val tmpReplicaSelector: ReplicaSelector = Utils.newInstance(className,
classOf[ReplicaSelector])
tmpReplicaSelector.configure(config.originals())
- tmpReplicaSelector
+ Plugin.wrapInstance(tmpReplicaSelector, metrics, className)
Review Comment:
I just noticed that this is not correct. Instead of `className`, the second
argument should be the name of the configuration:
`REPLICA_SELECTOR_CLASS_CONFIG`.
I fixed that in my PR adding KIP-877 support to the authorizer:
https://github.com/apache/kafka/pull/19050
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
