mimaison commented on code in PR #19286:
URL: https://github.com/apache/kafka/pull/19286#discussion_r2027343207
##########
core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java:
##########
@@ -413,24 +418,19 @@ void
testRemoteLogMetadataManagerWithEndpointConfigOverridden() throws IOExcepti
tp -> Optional.of(mockLog),
(topicPartition, offset) -> { },
brokerTopicStats,
- metrics) {
+ metrics,
+ endPoint) {
+ @Override
public RemoteStorageManager createRemoteStorageManager() {
return remoteStorageManager;
}
+ @Override
public RemoteLogMetadataManager createRemoteLogMetadataManager() {
return remoteLogMetadataManager;
}
}) {
-
- String host = "localhost";
- int port = 1234;
- String securityProtocol = "PLAINTEXT";
- Endpoint endpoint = new Endpoint(securityProtocol,
SecurityProtocol.PLAINTEXT, host, port);
- remoteLogManager.onEndPointCreated(endpoint);
- remoteLogManager.startup();
-
ArgumentCaptor<Map<String, Object>> capture =
ArgumentCaptor.forClass(Map.class);
- verify(remoteLogMetadataManager,
times(1)).configure(capture.capture());
+ verify(remoteLogMetadataManager,
times(2)).configure(capture.capture());
Review Comment:
This could be a comment
##########
core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java:
##########
@@ -441,7 +441,6 @@ public RemoteLogMetadataManager
createRemoteLogMetadataManager() {
@Test
void testStartup() {
- remoteLogManager.startup();
Review Comment:
Do we need to adjust or keep this test now that the `startup()` method does
not exist anymore?
##########
core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java:
##########
@@ -3011,7 +2996,6 @@ public RemoteLogMetadataManager
createRemoteLogMetadataManager() {
task.cleanupExpiredRemoteLogSegments();
- verifyNoMoreInteractions(remoteStorageManager);
Review Comment:
So should we assert that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
