AndrewJSchofield commented on code in PR #19247: URL: https://github.com/apache/kafka/pull/19247#discussion_r2005360228
########## core/src/test/java/kafka/server/share/SharePartitionTest.java: ########## @@ -6648,6 +6648,15 @@ public void testAcquireWhenBatchesRemovedForFetchOffsetForSameCachedBatch() { }); }); } + + private String assertionFailedMessage(SharePartition sharePartition) { Review Comment: If I understand the usage of this correctly, the hard-coded `5L` here should be a parameter to this method. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org