m1a2st commented on code in PR #19384: URL: https://github.com/apache/kafka/pull/19384#discussion_r2029892934
########## core/src/main/scala/kafka/server/KafkaRequestHandler.scala: ########## @@ -208,7 +208,7 @@ class KafkaRequestHandlerPool( /* a meter to track the average free capacity of the request handlers */ private val aggregateIdleMeter = metricsGroup.newMeter(requestHandlerAvgIdleMetricName, "percent", TimeUnit.NANOSECONDS) - this.logIdent = "[" + logAndThreadNamePrefix + " Kafka Request Handler on Broker " + brokerId + "], " + this.logIdent = "[" + logAndThreadNamePrefix + " Kafka Request Handler on Controller " + brokerId + "], " Review Comment: I think that we should use `${nodeName.capitalize}` instead of hard core, WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org