FrankYang0529 commented on PR #19111: URL: https://github.com/apache/kafka/pull/19111#issuecomment-2769816571
Hi @showuon, thanks for the suggestion. Following are all references about `fetchLogSegment` and `fetchIndex`. * InputStream fetchLogSegment(RemoteLogSegmentMetadata remoteLogSegmentMetadata, int startPosition) * RemoteLogManager#lookupTimestamp: https://github.com/apache/kafka/blob/1eea7f0528954ce8dcbcc4357ae2ef28c1d1e5f2/core/src/main/java/kafka/log/remote/RemoteLogManager.java#L653-L655 * RemoteLogManager#read: https://github.com/apache/kafka/blob/1eea7f0528954ce8dcbcc4357ae2ef28c1d1e5f2/core/src/main/java/kafka/log/remote/RemoteLogManager.java#L1744-L1748 * _LocalTieredStorageTest#verifyFetchedLogSegment: Fixed by this PR._ * InputStream fetchLogSegment(RemoteLogSegmentMetadata remoteLogSegmentMetadata, int startPosition, int endPosition) * LocalTieredStorageTest: All usage throws exception before creating input stream. * InputStream fetchIndex(RemoteLogSegmentMetadata remoteLogSegmentMetadata, IndexType indexType) * _TierStateMachine#readLeaderEpochCheckpoint and TierStateMachine#buildProducerSnapshotFile: Fixed by this PR._ * RemoteIndexCache#createCacheEntry: The input stream is supplied by a function and is closed in RemoteIndexCache#loadIndexFile. https://github.com/apache/kafka/blob/1eea7f0528954ce8dcbcc4357ae2ef28c1d1e5f2/storage/src/main/java/org/apache/kafka/storage/internals/log/RemoteIndexCache.java#L355-L357 * _LocalTieredStorageTest#verifyFetchedOffsetIndex, LocalTieredStorageTest#verifyFetchedTimeIndex, LocalTieredStorageTest#verifyFetchedTransactionIndex, LocalTieredStorageTest#verifyLeaderEpochCheckpoint, and LocalTieredStorageTest#verifyProducerSnapshot: Fixed by this PR. The input stream is closed in LocalTieredStorageTest#verifyFileContents._ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org