chia7712 commented on code in PR #19251:
URL: https://github.com/apache/kafka/pull/19251#discussion_r2006087036
##########
core/src/test/scala/unit/kafka/server/HeartbeatRequestTest.scala:
##########
@@ -36,17 +36,7 @@ class HeartbeatRequestTest(cluster: ClusterInstance) extends
GroupCoordinatorBas
new ClusterConfigProperty(key =
GroupCoordinatorConfig.OFFSETS_TOPIC_PARTITIONS_CONFIG, value = "1"),
new ClusterConfigProperty(key =
GroupCoordinatorConfig.OFFSETS_TOPIC_REPLICATION_FACTOR_CONFIG, value = "1")
))
- def testHeartbeatWithOldConsumerGroupProtocolAndNewGroupCoordinator(): Unit
= {
- testHeartbeat()
- }
-
- @ClusterTest(types = Array(Type.KRAFT, Type.CO_KRAFT), serverProperties =
Array(
- new ClusterConfigProperty(key =
GroupCoordinatorConfig.NEW_GROUP_COORDINATOR_ENABLE_CONFIG, value = "false"),
- new ClusterConfigProperty(key =
GroupCoordinatorConfig.GROUP_COORDINATOR_REBALANCE_PROTOCOLS_CONFIG, value =
"classic"),
- new ClusterConfigProperty(key =
GroupCoordinatorConfig.OFFSETS_TOPIC_PARTITIONS_CONFIG, value = "1"),
- new ClusterConfigProperty(key =
GroupCoordinatorConfig.OFFSETS_TOPIC_REPLICATION_FACTOR_CONFIG, value = "1")
- ))
- def testHeartbeatWithOldConsumerGroupProtocolAndOldGroupCoordinator(): Unit
= {
+ def testHeartbeatWithOldConsumerGroupProtocol(): Unit = {
testHeartbeat()
Review Comment:
it seems we can merge `testHeartbeat` into
`testHeartbeatWithOldConsumerGroupProtocol`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
