smjn commented on code in PR #19369:
URL: https://github.com/apache/kafka/pull/19369#discussion_r2028490277
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareConsumeRequestManager.java:
##########
@@ -971,9 +971,11 @@ private void
handlePartitionError(ShareAcknowledgeResponseData.PartitionData par
AtomicBoolean shouldRetry) {
if (partitionError.exception() != null) {
boolean retry = false;
- if (partitionError == Errors.NOT_LEADER_OR_FOLLOWER ||
partitionError == Errors.FENCED_LEADER_EPOCH) {
+ if (partitionError == Errors.NOT_LEADER_OR_FOLLOWER ||
partitionError == Errors.FENCED_LEADER_EPOCH || partitionError ==
Errors.UNKNOWN_TOPIC_OR_PARTITION) {
Review Comment:
could we add unit tests to verify this?
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareConsumerImpl.java:
##########
@@ -937,7 +938,7 @@ private void sendAcknowledgementsAndLeaveGroup(final Timer
timer, final AtomicRe
// If users have fatal error, they will get some exceptions in the
background queue.
// When running unsubscribe, these exceptions should be ignored,
or users can't unsubscribe successfully.
processBackgroundEvents(unsubscribeEvent.future(), timer, e -> (e
instanceof GroupAuthorizationException
- || e instanceof TopicAuthorizationException));
+ || e instanceof TopicAuthorizationException || e instanceof
InvalidTopicException));
Review Comment:
same as above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
