lucasbru commented on code in PR #19219:
URL: https://github.com/apache/kafka/pull/19219#discussion_r2028473669
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -8148,7 +8174,10 @@ private TaskAssignor streamsGroupAssignor(String
groupId) {
* Get the assignor of the provided streams group.
*/
private Map<String, String> streamsGroupAssignmentConfigs(String groupId) {
- return Map.of("group.streams.num.standby.replicas", "0");
+ Optional<GroupConfig> groupConfig =
groupConfigManager.groupConfig(groupId);
+ final Integer numStandbyReplicas =
groupConfig.map(GroupConfig::streamsNumStandbyReplicas)
+ .orElse(config.streamsGroupNumStandbyReplicas());
+ return Map.of("num.standby.replicas", numStandbyReplicas.toString());
Review Comment:
This is just convention. We don't need the prefix in this map. But we could
keep it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
