chia7712 commented on code in PR #19359:
URL: https://github.com/apache/kafka/pull/19359#discussion_r2030221993


##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -2226,6 +2224,16 @@ private CoordinatorResult<StreamsGroupHeartbeatResult, 
CoordinatorRecord> stream
             );
         }
 
+        if (group.isShutdownRequested()) {
+            returnedStatus.add(
+                new StreamsGroupHeartbeatResponseData.Status()
+                    
.setStatusCode(StreamsGroupHeartbeatResponse.Status.SHUTDOWN_APPLICATION.code())
+                    .setStatusDetail(
+                        "A KafkaStreams instance encountered a fatal error and 
requested a shutdown for the entire application."

Review Comment:
   Is it useful to propagate the member id which request to shutdown entire 
application?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to