chia7712 commented on code in PR #19356:
URL: https://github.com/apache/kafka/pull/19356#discussion_r2030311152
##########
server-common/src/main/java/org/apache/kafka/queue/KafkaEventQueue.java:
##########
@@ -444,7 +445,7 @@ public KafkaEventQueue(
LogContext logContext,
String threadNamePrefix
) {
- this(time, logContext, threadNamePrefix, VoidEvent::new);
+ this(time, logContext, threadNamePrefix, VoidEvent.INSTANCE);
Review Comment:
maybe we can replace it by `() -> {}`?
##########
server-common/src/main/java/org/apache/kafka/queue/EventQueue.java:
##########
@@ -66,16 +66,20 @@ public String toString() {
}
}
- class NoDeadlineFunction implements Function<OptionalLong, OptionalLong> {
Review Comment:
Maybe we can remove this class and use `ignored -> OptionalLong.empty()` as
replacement
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
