mimaison commented on code in PR #19406: URL: https://github.com/apache/kafka/pull/19406#discussion_r2031923532
########## core/src/main/scala/kafka/server/ControllerApis.scala: ########## @@ -84,7 +85,7 @@ class ControllerApis( val configHelper = new ConfigHelper(metadataCache, config, metadataCache) val requestHelper = new RequestHandlerHelper(requestChannel, quotas, time) val runtimeLoggerManager = new RuntimeLoggerManager(config.nodeId, logger.underlying) - private val aclApis = new AclApis(authHelper, authorizer, requestHelper, "controller", config) + private val aclApis = new AclApis(authHelper, authorizer, requestHelper, ProcessRole.ControllerRole.toString, config) Review Comment: Could we change the `AclApis` constructor to accept a `ProcessRole` instance instead of a `String`? It seems this field is only used in a call to `String.format()` that would automatically call `toString()` for us. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
