smjn commented on code in PR #18976:
URL: https://github.com/apache/kafka/pull/18976#discussion_r2032618471
##########
clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java:
##########
@@ -10780,6 +10784,156 @@ public void
testAlterShareGroupOffsetsWithErrorInOnePartition() throws Exception
}
}
+ @Test
+ public void testDeleteShareGroupOffsetsOptionsWithBatchedApi() throws
Exception {
+ final Cluster cluster = mockCluster(3, 0);
+ final Time time = new MockTime();
+
+ try (AdminClientUnitTestEnv env = new AdminClientUnitTestEnv(time,
cluster,
+ AdminClientConfig.RETRIES_CONFIG, "0")) {
+ env.kafkaClient().setNodeApiVersions(NodeApiVersions.create());
+
+
env.kafkaClient().prepareResponse(prepareFindCoordinatorResponse(Errors.NONE,
env.cluster().controller()));
+
+ final Set<TopicPartition> partitions = Collections.singleton(new
TopicPartition("A", 0));
+ final DeleteShareGroupOffsetsOptions options = new
DeleteShareGroupOffsetsOptions();
+
+ env.adminClient().deleteShareGroupOffsets(GROUP_ID, partitions,
options);
+
+ final MockClient mockClient = env.kafkaClient();
+ waitForRequest(mockClient, ApiKeys.DELETE_SHARE_GROUP_OFFSETS);
+
+ ClientRequest clientRequest = mockClient.requests().peek();
+ assertNotNull(clientRequest);
+ DeleteShareGroupOffsetsRequestData data =
((DeleteShareGroupOffsetsRequest.Builder)
clientRequest.requestBuilder()).build().data();
+ assertEquals(GROUP_ID, data.groupId());
+ assertEquals(1, data.topics().size());
+ assertEquals(Collections.singletonList("A"),
+
data.topics().stream().map(DeleteShareGroupOffsetsRequestData.DeleteShareGroupOffsetsRequestTopic::topicName).collect(Collectors.toList()));
Review Comment:
just `toList()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
