ShivsundarR opened a new pull request, #19417:
URL: https://github.com/apache/kafka/pull/19417

   *What*
   
   - This is in continuation to 
https://github.com/apache/kafka/commit/1da30bdedf457b507ed9879a78e31c9e4c74026c,
 where we will only choose the acknowledgement mode based on the config 
(`share.acknowledgement.mod`e) and not on the basis of how the user designs the 
application.
   - The default value of the config is `IMPLICIT`, so if any 
empty/null/invalid value is configured, then the mode defaults to `IMPLICIT`.
   - Removed AcknowledgementModes `UNKNOWN` and `PENDING` as they are no longer 
required.
   - Added code to ensure if the application has any unacknowledged records in 
a batch in "`explicit`" mode, then it will throw an `IllegalStateException`. 
The expectation is if the mode is "explicit", all the records received in that 
`poll()` would be acknowledged before the next call to `poll()`.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to