Yunyung commented on code in PR #19419: URL: https://github.com/apache/kafka/pull/19419#discussion_r2036424966
########## metadata/src/main/java/org/apache/kafka/metadata/util/SnapshotFileReader.java: ########## @@ -96,12 +96,16 @@ private void handleNextBatch() { return; } FileChannelRecordBatch batch = batchIterator.next(); + lastOffset = batch.lastOffset(); + if (!batchIterator.hasNext()) { + // Ensure the high watermark is updated before the MetadataLoader handles its final batch Review Comment: Remove extra space in the comment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org