Re: [PR] KAFKA-19118: Enable KIP-1071 in InternalTopicIntegrationTest [kafka]

[via GitHub]

FrankYang0529 commented on code in PR #19425:
URL: https://github.com/apache/kafka/pull/19425#discussion_r2037183291


##########
streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/utils/EmbeddedKafkaCluster.java:
##########
@@ -140,6 +140,19 @@ public EmbeddedKafkaCluster(final int numBrokers,
         this.time = new MockTime(mockTimeMillisStart, mockTimeNanoStart);
     }
 
+    public static EmbeddedKafkaCluster withStreamsRebalanceProtocol(final int 
numBrokers) {
+        final Properties props = new Properties();
+        
props.setProperty(GroupCoordinatorConfig.GROUP_COORDINATOR_REBALANCE_PROTOCOLS_CONFIG,
 "classic,consumer,streams");
+        props.setProperty(ServerConfigs.UNSTABLE_API_VERSIONS_ENABLE_CONFIG, 
"true");
+        return new EmbeddedKafkaCluster(numBrokers, props);

Review Comment:
   nit: can we simplify this like:
   
   ```java
       public static EmbeddedKafkaCluster withStreamsRebalanceProtocol(final 
int numBrokers) {
           return withStreamsRebalanceProtocol(numBrokers, new Properties());
       }
   
       public static EmbeddedKafkaCluster withStreamsRebalanceProtocol(final 
int numBrokers, final Properties props) {
   ```



##########
streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/SmokeTestDriverIntegrationTest.java:
##########
@@ -53,21 +51,17 @@
 @Timeout(600)
 @Tag("integration")
 public class SmokeTestDriverIntegrationTest {
-    public static EmbeddedKafkaCluster cluster;
+    public static EmbeddedKafkaCluster CLUSTER = 
EmbeddedKafkaCluster.withStreamsRebalanceProtocol(3);

Review Comment:
   ```
       public static final EmbeddedKafkaCluster CLUSTER = 
EmbeddedKafkaCluster.withStreamsRebalanceProtocol(3);
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org