apoorvmittal10 commented on code in PR #19378:
URL: https://github.com/apache/kafka/pull/19378#discussion_r2037272992
##########
clients/src/main/java/org/apache/kafka/common/requests/AlterShareGroupOffsetsRequest.java:
##########
@@ -41,7 +41,7 @@ public static class Builder extends
AbstractRequest.Builder<AlterShareGroupOffse
private final AlterShareGroupOffsetsRequestData data;
public Builder(AlterShareGroupOffsetsRequestData data) {
- this(data, true);
+ this(data, false);
}
public Builder(AlterShareGroupOffsetsRequestData data, boolean
enableUnstableLastVersion) {
Review Comment:
Shouldn't we get rid of `enableUnstableLastVersion` constructor i.e.
`Builder(AlterShareGroupOffsetsRequestData data, boolean
enableUnstableLastVersion)`, default is `false` for `enableUnstableLastVersion`
in `AbstractRequest`. So only method would be:
```
public Builder(AlterShareGroupOffsetsRequestData data) {
super(ApiKeys.ALTER_SHARE_GROUP_OFFSETS);
this.data = data;
}
##########
clients/src/main/resources/common/message/ShareAcknowledgeRequest.json:
##########
@@ -18,34 +18,33 @@
"type": "request",
"listeners": ["broker"],
"name": "ShareAcknowledgeRequest",
- "validVersions": "0",
- "flexibleVersions": "0+",
- // The ShareAcknowledgeRequest API is added as part of KIP-932 and is still
under
- // development. Hence, the API is not exposed by default by brokers unless
- // explicitly enabled.
- "latestVersionUnstable": true,
+ // Version 0 was used for early access of KIP-932 in Apache Kafka 4.0 but
removed in Apacke Kafka 4.1.
+ //
+ // Version 1 is the initial stable version (KIP-932).
+ "validVersions": "1",
Review Comment:
This will ensure that version 4.0 client requests are not accepted by 4.1
broker, correct? Then why do we need to update the version number for
individual fields. They should be on 0+ itself and fields changed/added from
4.0 -> 4.1 should be on 1+, isn't it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
