chia7712 commented on code in PR #19371:
URL: https://github.com/apache/kafka/pull/19371#discussion_r2042115495


##########
clients/src/main/java/org/apache/kafka/common/config/TopicConfig.java:
##########
@@ -214,6 +214,9 @@ public class TopicConfig {
         "configuration. If message.timestamp.type=CreateTime, the message will 
be rejected if the difference in " +
         "timestamps exceeds this specified threshold. This configuration is 
ignored if message.timestamp.type=LogAppendTime.";
 
+    // visible for testing 
+    public static final String INTERNAL_SEGMENT_BYTES_CONFIG = 
"internal.segment.bytes";

Review Comment:
   `TopicConfig` is a public class, so could you please move it to `LogConfig`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to