squah-confluent commented on code in PR #19497: URL: https://github.com/apache/kafka/pull/19497#discussion_r2047531203
########## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java: ########## @@ -194,9 +194,16 @@ public OffsetMetadataManager build() { /** * The open transactions (producer ids) keyed by group. + * Tracks whether groups have any open transactions. */ private final TimelineHashMap<String, TimelineHashSet<Long>> openTransactionsByGroup; Review Comment: I wanted to replace this map entirely, but we use it in `cleanupExpiredOffsets` to check whether a group has any pending transactions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org