cadonna commented on code in PR #19507:
URL: https://github.com/apache/kafka/pull/19507#discussion_r2056016841
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##########
@@ -553,7 +553,7 @@ private void handleTasksWithStateUpdater(final Map<TaskId,
Set<TopicPartition>>
private void handleTasksPendingInitialization() {
// All tasks pending initialization are not part of the usual
bookkeeping
for (final Task task : tasks.drainPendingTasksToInit()) {
- closeTaskClean(task, Collections.emptySet(),
Collections.emptyMap());
+ closeTaskClean(task, new HashSet<>(), new HashMap<>());
Review Comment:
I believe something like in the following code, will avoid the leak:
https://github.com/apache/kafka/blob/efd785274e7c6dd75a3286ca6da1379830366acc/streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java#L1325
Basically, we need to collect the failed tasks in `tasksToCloseDirty` and
close those tasks dirty. The thrown exception is swallowed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
