jsancio commented on code in PR #19353:
URL: https://github.com/apache/kafka/pull/19353#discussion_r2056567679
##########
clients/src/main/java/org/apache/kafka/common/requests/AbstractResponse.java:
##########
@@ -110,7 +111,7 @@ public static AbstractResponse parseResponse(ByteBuffer
buffer, RequestHeader re
return AbstractResponse.parseResponse(apiKey, new
ByteBufferAccessor(buffer), apiVersion);
}
- public static AbstractResponse parseResponse(ApiKeys apiKey,
ByteBufferAccessor readable, short version) {
+ public static AbstractResponse parseResponse(ApiKeys apiKey, Readable
readable, short version) {
Review Comment:
Why don't you also fix the static method `AbstractResponse
parseResponse(ByteBuffer, RequestHeader)`?
Are you planning to fix `RequestHeader` and `ResponseHeader` to use
`Readable` instead of `ByteBuffer`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
