cmccabe commented on code in PR #19545:
URL: https://github.com/apache/kafka/pull/19545#discussion_r2057607502
##########
metadata/src/main/java/org/apache/kafka/metadata/bootstrap/BootstrapMetadata.java:
##########
@@ -117,7 +117,7 @@ public List<ApiMessageAndVersion> records() {
}
public MetadataVersion metadataVersion() {
- return metadataVersion;
+ return MetadataVersion.fromFeatureLevel(metadataVersionLevel);
Review Comment:
In a data loss scenario with `kraft.version=1` we would need to re-format
the directory and re-add the voter, so there would be no more
`bootstrap.metadata` file.
(If you delete some files in the raft log directory but not others, bad
things may happen, of course, but that is no different than today; it breaks
the Raft invariants.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
