mjsax commented on PR #18297: URL: https://github.com/apache/kafka/pull/18297#issuecomment-2831763614
FYI: https://github.com/apache/kafka/pull/19570 I usually prefer to verify the error message in tests, to avoid incorrect setups... This would be better ``` final IllegalArgumentException expected = assertThrows(IllegalArgumentException.class, () -> serializer.configure(props, false)); assertThat(e.getMessage(), is("...")); ``` Did not want to go the extra mile and add it everything after the fact, but only fixed the issue itself. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
