smjn commented on code in PR #19624:
URL: https://github.com/apache/kafka/pull/19624#discussion_r2071865341
##########
share-coordinator/src/main/java/org/apache/kafka/coordinator/share/ShareCoordinatorService.java:
##########
@@ -322,7 +322,7 @@ private CompletableFuture<Void>
performRecordPruning(TopicPartition tp) {
return;
}
- log.info("Pruning records in {} till offset {}.", tp, off);
+ log.debug("Pruning records in {} till offset {}.", tp, off);
Review Comment:
It was suggested in the initial PR because of the `writer.deleteRecords` was
implemented (for all partitions in config)
https://github.com/apache/kafka/pull/18014#discussion_r1871352116
However, later the code re-written such that `writer.deleteRecords` would
get called only for active shards and so exp on every call is no longer the
case. We can move that back to `error`.
Great catch!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
