chia7712 commented on code in PR #19609:
URL: https://github.com/apache/kafka/pull/19609#discussion_r2073790005
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThread.java:
##########
@@ -154,16 +153,12 @@ void runOnce() {
lastPollTimeMs = currentTimeMs;
final long pollWaitTimeMs = requestManagers.entries().stream()
- .filter(Optional::isPresent)
- .map(Optional::get)
.map(rm -> rm.poll(currentTimeMs))
.map(networkClientDelegate::addAll)
.reduce(MAX_POLL_TIMEOUT_MS, Math::min);
Review Comment:
thanks for the sharing. nice find!
BTW, do you know the purpose of max poll time? it seems we don't honor the
`timeUntilNextPollMs` configured by the rm. If the value larger than 5 secs is
invalid, should we throw exception in `PollResult`? Additionally, maybe the
default `timeUntilNextPollMs` should be configured to 5 seconds (or
optional.empty) as the default value is useless.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
