lucasbru commented on code in PR #19625:
URL: https://github.com/apache/kafka/pull/19625#discussion_r2075106640
##########
tests/kafkatest/tests/streams/streams_standby_replica_test.py:
##########
@@ -47,19 +47,23 @@ def __init__(self, test_context):
})
@cluster(num_nodes=10)
- @matrix(metadata_quorum=[quorum.isolated_kraft])
- def test_standby_tasks_rebalance(self, metadata_quorum):
+ @matrix(metadata_quorum=[quorum.combined_kraft],
+ group_protocol=["classic", "streams"])
+ def test_standby_tasks_rebalance(self, metadata_quorum, group_protocol):
# TODO KIP-441: consider rewriting the test for
HighAvailabilityTaskAssignor
configs = self.get_configs(
- group_protocol="classic",
+ group_protocol=group_protocol,
extra_configs=
-
",sourceTopic=%s,sinkTopic1=%s,sinkTopic2=%s,internal.task.assignor.class=org.apache.kafka.streams.processor.internals.assignment.LegacyStickyTaskAssignor"
% (
+
",application.id=test_standby_tasks_rebalance,sourceTopic=%s,sinkTopic1=%s,sinkTopic2=%s,internal.task.assignor.class=org.apache.kafka.streams.processor.internals.assignment.LegacyStickyTaskAssignor"
% (
Review Comment:
Or just not hardcode it in StreamsStandByReplicaTest. We hardcode it
`extra_configs` in other system tests as well, maybe this is a good pattern
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
