adixitconfluent commented on code in PR #19598:
URL: https://github.com/apache/kafka/pull/19598#discussion_r2075221793
##########
core/src/main/java/kafka/server/share/DelayedShareFetch.java:
##########
@@ -344,20 +349,22 @@ LinkedHashMap<TopicIdPartition, Long>
acquirablePartitions(
sharePartitionsForAcquire.forEach((topicIdPartition, sharePartition)
-> {
// Add the share partition to the list of partitions to be fetched
only if we can
// acquire the fetch lock on it.
- if (sharePartition.maybeAcquireFetchLock()) {
+ if (sharePartition.maybeAcquireFetchLock(fetchId)) {
try {
+ log.trace("Fetch lock for share partition {} has been
acquired by {}", sharePartition, fetchId);
Review Comment:
I am utilizing the combination of `shareFetch.groupId()`-`topicIdPartition`
now to log the share partition.
`log.trace("Fetch lock for share partition {}-{} has been acquired by {}",
shareFetch.groupId(), topicIdPartition, fetchId);`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
