Yunyung commented on code in PR #19635:
URL: https://github.com/apache/kafka/pull/19635#discussion_r2076072025
##########
core/src/test/scala/integration/kafka/api/AuthorizerIntegrationTest.scala:
##########
@@ -924,6 +924,55 @@ class AuthorizerIntegrationTest extends
AbstractAuthorizerIntegrationTest {
sendRequests(requestKeyToRequest, false, topicNames)
}
+ /**
+ * Test that the produce request fails with TOPIC_AUTHORIZATION_FAILED if
the topic does not exist from version 3 to 12.
+ * The version 13 is covered by testAuthorizationWithTopicNotExisting.
+ */
+ @Test
+ def
testAuthorizationWithTopicNotExistingForProduceRequestVersionLessThan13(): Unit
= {
+ authorizationForProduceRequestVersionLessThan13(false)
+ }
+
+ /**
+ * Test that the produce request fails with TOPIC_AUTHORIZATION_FAILED if
the topic exists
+ * but the client doesn't have permission from version 3 to 12.
+ * The version 13 is covered by testAuthorizationWithTopicExisting.
+ */
+ @Test
+ def testAuthorizationWithTopicExistingForProduceRequestVersionLessThan13():
Unit = {
+ authorizationForProduceRequestVersionLessThan13(true)
+ }
+
+ def authorizationForProduceRequestVersionLessThan13(createTopic: Boolean):
Unit = {
+ if (createTopic) {
+ sendRequests(mutable.Map(ApiKeys.CREATE_TOPICS -> createTopicsRequest))
Review Comment:
Follow junrao, it would be good to follow testTopicIdAuthorization method?
- Use @ParameterizedTest and rename the parameter to withTopicExisting for
consistent code style in this file.
- Use `createTopicWithBrokerPrincipal`.
```
@ParameterizedTest
@CsvSource(value = Array("false", "true"))
def testTopicIdAuthorization(withTopicExisting: Boolean): Unit = {
val topicId = if (withTopicExisting) {
createTopicWithBrokerPrincipal(topic)
getTopicIds()(topic)
} else {
Uuid.randomUuid()
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
