jsancio commented on code in PR #19589:
URL: https://github.com/apache/kafka/pull/19589#discussion_r2076235288
##########
raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java:
##########
@@ -2280,6 +2280,25 @@ private boolean handleApiVersionsResponse(
);
}
+ private boolean handleAddVoterResponse(
+ RaftResponse.Inbound responseMetadata,
+ long currentTimeMs
+ ) {
+ RemoveRaftVoterResponseData data = (RemoveRaftVoterResponseData)
responseMetadata.data();
+
+ Errors error = Errors.forCode(data.errorCode());
+
+ if (error == Errors.NONE || error == Errors.UNSUPPORTED_VERSION ||
error == Errors.DUPLICATE_VOTER) {
+ return true;
+ } else if (error == Errors.REQUEST_TIMED_OUT) {
+ FollowerState follower = quorum.followerStateOrThrow();
+ follower.resetUpdateVoterPeriod(currentTimeMs);
+ return true;
Review Comment:
Yes. But you can make a similar argument for `NONE` and `DUPLICATE_VOTER`.
Meaning the voter is already in the voter set so back off.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
