smjn commented on code in PR #18929:
URL: https://github.com/apache/kafka/pull/18929#discussion_r2077324458
##########
clients/src/main/java/org/apache/kafka/common/requests/AlterShareGroupOffsetsRequest.java:
##########
@@ -78,6 +78,24 @@ public static AlterShareGroupOffsetsRequest parse(Readable
readable, short versi
);
}
+ public static
AlterShareGroupOffsetsResponseData.AlterShareGroupOffsetsResponseTopic
getErrorAlterShareGroup(
Review Comment:
in AK `get` prefix on methods is generally avoided. You could perhaps use
the infinitely more ubiquitous name - just `from`
```
public static
AlterShareGroupOffsetsResponseData.AlterShareGroupOffsetsResponseTopic
from(Errors error)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
