josefk31 commented on code in PR #19644:
URL: https://github.com/apache/kafka/pull/19644#discussion_r2082585404


##########
tests/kafkatest/tests/core/reassign_partitions_test.py:
##########
@@ -164,6 +167,14 @@ def test_reassign_partitions(self, bounce_brokers, 
reassign_from_offset_zero, me
                                            self.kafka, self.topic,
                                            throughput=self.producer_throughput,
                                            enable_idempotence=True,

Review Comment:
   Thanks; this is a good suggestion. Originally I wanted to be a bit more 
cautious with this change and keep behaviour the same but adjust one small 
thing (what we check for).
   
   I think `enable_idempotence=False` should achieve what we want anyways. 
   
   1. `NOT_LEADER_OR_FOLLOWER` batches are retried. By default there are 
`INT_MAX` retries. 
   2. Batches will not get stuck, holding up produce on a given partition since 
`enable.idempotence=false`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to