frankvicky commented on code in PR #19679:
URL: https://github.com/apache/kafka/pull/19679#discussion_r2083898755
##########
metadata/src/test/java/org/apache/kafka/image/TopicsImageTest.java:
##########
@@ -446,7 +446,7 @@ public void testClearElrRecordForNonExistTopic() {
@Test
public void testTopicDeltaElectionStatsWithEmptyImage() {
- TopicImage image = new TopicImage("topic", Uuid.randomUuid(),
Collections.EMPTY_MAP);
+ TopicImage image = new TopicImage("topic", Uuid.randomUuid(),
Collections.<Integer, PartitionRegistration>emptyMap());
Review Comment:
> Just wondering, what's the purpose of the screenshot?
Prove the patch works and make the reviewer's life easier.
##########
metadata/src/test/java/org/apache/kafka/image/TopicsImageTest.java:
##########
@@ -446,7 +446,7 @@ public void testClearElrRecordForNonExistTopic() {
@Test
public void testTopicDeltaElectionStatsWithEmptyImage() {
- TopicImage image = new TopicImage("topic", Uuid.randomUuid(),
Collections.EMPTY_MAP);
+ TopicImage image = new TopicImage("topic", Uuid.randomUuid(),
Collections.<Integer, PartitionRegistration>emptyMap());
Review Comment:
> Just wondering, what's the purpose of the screenshot?
Prove the patch works and make the reviewer's life easier.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
