[ 
https://issues.apache.org/jira/browse/KAFKA-19267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17950992#comment-17950992
 ] 

Chia-Ping Tsai commented on KAFKA-19267:
----------------------------------------

{quote}
We should replace the hardcoded value with 
`ApiKeys.LIST_OFFSETS.oldestVersion()`.
{quote}

good idea!

> the min version used by ListOffsetsRequest should be 1 rather than 0
> --------------------------------------------------------------------
>
>                 Key: KAFKA-19267
>                 URL: https://issues.apache.org/jira/browse/KAFKA-19267
>             Project: Kafka
>          Issue Type: Improvement
>            Reporter: Chia-Ping Tsai
>            Assignee: Yunchi Pang
>            Priority: Minor
>
> in the protocol, `ListOffsetsRequest` v0 is unsupported - but in the code 
> base we still set the  oldestAllowedVersion to 0. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to