dajac commented on code in PR #19515:
URL: https://github.com/apache/kafka/pull/19515#discussion_r2085263820
##########
core/src/test/scala/unit/kafka/server/ConsumerProtocolMigrationTest.scala:
##########
@@ -1197,15 +1201,17 @@ class ConsumerProtocolMigrationTest(cluster:
ClusterInstance) extends GroupCoord
).asJava)
).asJava),
fetchOffsets(
- groupId = groupId,
- memberId = memberId1,
- memberEpoch = 1,
- partitions = List(
- new TopicPartition("foo", 0),
- new TopicPartition("foo", 1),
- new TopicPartition("foo", 2)
- ),
- requireStable = false,
+ group = new OffsetFetchRequestData.OffsetFetchRequestGroup()
+ .setGroupId(groupId)
+ .setMemberId(memberId1)
+ .setMemberEpoch(1)
+ .setTopics(List(
+ new OffsetFetchRequestData.OffsetFetchRequestTopics()
+ .setName("foo")
+ .setTopicId(topicId)
+ .setPartitionIndexes(List[Integer](0, 1, 2).asJava)
+ ).asJava),
+ requireStable = true,
Review Comment:
nope, let me revert it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
