squah-confluent commented on code in PR #19496:
URL: https://github.com/apache/kafka/pull/19496#discussion_r2086375860
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java:
##########
@@ -1006,7 +1006,7 @@ public boolean cleanupExpiredOffsets(String groupId,
List<CoordinatorRecord> rec
TimelineHashMap<String, TimelineHashMap<Integer, OffsetAndMetadata>>
offsetsByTopic =
offsets.offsetsByGroup.get(groupId);
if (offsetsByTopic == null) {
- return true;
+ return !openTransactions.contains(groupId);
Review Comment:
Thanks for reviewing. I reworded the javadoc. Let me know what you think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
