m1a2st commented on code in PR #19651:
URL: https://github.com/apache/kafka/pull/19651#discussion_r2086737025
##########
clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/consumer/ShareConsumerTest.java:
##########
@@ -2994,35 +2992,4 @@ private void waitForAssignment(String groupId,
List<TopicPartition> tps) {
throw new RuntimeException(e);
}
}
-
- public static class SerializerImpl implements Serializer<byte[]> {
Review Comment:
I noticed that `BaseConsumerTest.scala` contains the same class, but it's
only used in `PlaintextConsumerTest.scala`. So, when we rewrite
`PlaintextConsumerTest.scala` in Java, we should move this class to a utility
class. I will revert now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
