chia7712 commented on code in PR #19724:
URL: https://github.com/apache/kafka/pull/19724#discussion_r2093356674
##########
core/src/main/scala/kafka/server/KafkaApis.scala:
##########
@@ -384,15 +385,15 @@ class KafkaApis(val requestChannel: RequestChannel,
/**
* Handle a produce request
*/
- def handleProduceRequest(request: RequestChannel.Request, requestLocal:
RequestLocal): Unit = {
+ def handleProduceRequest(request: RequestChannel.Request, requestLocal:
RequestLocal): CompletableFuture[Unit] = {
Review Comment:
ditto
##########
core/src/main/scala/kafka/server/KafkaApis.scala:
##########
@@ -135,6 +135,7 @@ class KafkaApis(val requestChannel: RequestChannel,
}
forwardingManager.forwardRequest(request, responseCallback)
+ CompletableFuture.completedFuture[Unit](())
Review Comment:
It seems to me `forwardToController` does not use the `CompletableFuture`
actually. Maybe we can add it in the future if we do need it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
