chia7712 commented on PR #19749: URL: https://github.com/apache/kafka/pull/19749#issuecomment-2889098456
> For num-partitions, there is partition-count. We need to check which one is correct in the code. There's a discrepancy in the naming of the partition configuration. The code uses `num-partitions`, while KIP-848 and the documentation use `partition-count`. https://github.com/apache/kafka/blob/6596ba3a783c91da2687aaceda91be2510321a60/coordinator-common/src/main/java/org/apache/kafka/coordinator/common/runtime/CoordinatorRuntimeMetricsImpl.java#L44 Since KIP-848 has already been released, the more suitable approach would be to modify the documentation to use num-partitions to align with the current production code, rather than changing the code itself. @YutaLin Please address @dajac comments. the `p95` should be added to the existent items in the table. for example ``` <tr> <td>Event Queue Time (Ms)</td> <td>kafka.server:type=group-coordinator-metrics,name=event-queue-time-ms-[max|p50|p95|p99|p999]</td> <td>The time that an event spent waiting in the queue to be processed</td> </tr> ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
