chia7712 commented on code in PR #19371:
URL: https://github.com/apache/kafka/pull/19371#discussion_r2097427388
##########
server-common/src/main/java/org/apache/kafka/server/config/ServerTopicConfigSynonyms.java:
##########
@@ -47,9 +48,11 @@ public final class ServerTopicConfigSynonyms {
* both the first and the second synonyms are configured, we will use only
the value of
* the first synonym and ignore the second.
*/
- // Topic configs with no mapping to a server config can be found in
`LogConfig.CONFIGS_WITH_NO_SERVER_DEFAULTS`
public static final Map<String, List<ConfigSynonym>>
ALL_TOPIC_CONFIG_SYNONYMS = Utils.mkMap(
sameNameWithLogPrefix(TopicConfig.SEGMENT_BYTES_CONFIG),
+ // Due to the internal.segment.bytes is in storage module, thus we
could not use the
+ // LogConfig#INTERNAL_SEGMENT_BYTES_CONFIG directly. We need to use
the string value instead.
+ sameNameWithInternalLogPrefix("internal.segment.bytes"),
Review Comment:
We currently don't have small segment tests for Kraft topics. Therefore, a
more effective way to streamline this PR would be to support topic-level
configuration only. This means the new internal configuration
(`internal.segment.bytes`) would apply exclusively to user topics.
We can revisit this config for Kraft topics in the future if it needs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
