AndrewJSchofield commented on code in PR #19758:
URL: https://github.com/apache/kafka/pull/19758#discussion_r2097734386
##########
tools/src/main/java/org/apache/kafka/tools/streams/StreamsGroupCommandOptions.java:
##########
@@ -23,18 +23,25 @@
import org.slf4j.LoggerFactory;
import java.util.Arrays;
+import java.util.HashSet;
import java.util.List;
+import java.util.Set;
import java.util.stream.Collectors;
import joptsimple.OptionSpec;
+import static org.apache.kafka.tools.ToolsUtils.minus;
+
public class StreamsGroupCommandOptions extends CommandDefaultOptions {
public static final Logger LOGGER =
LoggerFactory.getLogger(StreamsGroupCommandOptions.class);
public static final String BOOTSTRAP_SERVER_DOC = "REQUIRED: The server(s)
to connect to.";
public static final String GROUP_DOC = "The streams group we wish to act
on.";
public static final String LIST_DOC = "List all streams groups.";
public static final String DESCRIBE_DOC = "Describe streams group and list
offset lag related to given group.";
+ private static final String ALL_GROUPS_DOC = "Apply to all Streams
groups.";
Review Comment:
nit: It seems to me that the capitalization which we are using in general is
"streams groups" rather than "Streams groups". I know that this is being used
to support Kafka Streams, but I still contend that "streams groups" is better.
Please could you align the capitalization across all messages in this tool.
Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
