jsancio commented on code in PR #19745:
URL: https://github.com/apache/kafka/pull/19745#discussion_r2098749462
##########
core/src/main/scala/kafka/server/BrokerServer.scala:
##########
@@ -411,7 +411,7 @@ class BrokerServer(
config,
"heartbeat",
s"broker-${config.nodeId}-",
- config.brokerSessionTimeoutMs / 2 // KAFKA-14392
+ config.brokerHeartbeatIntervalMs
Review Comment:
Given the broker side request timeout and scheduling logic this period is
actually `2 * brokerHeartbeatIntervalMs`. Are you planning to fix this so that
the period is actually `brokerHeartbeatIntervalMs`?
Should we change the config validation logic so that `2 *
brokerHeartbeatIntervalMs < brokerSessionTimeoutMs`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
