Re: [PR] MINOR: Cleanups in Test Common Module [kafka]

[via GitHub]

m1a2st commented on code in PR #19775:
URL: https://github.com/apache/kafka/pull/19775#discussion_r2100149965


##########
test-common/test-common-runtime/src/main/java/org/apache/kafka/common/test/junit/ClusterTestExtensions.java:
##########
@@ -268,7 +268,7 @@ private List<TestTemplateInvocationContext> 
processClusterTestInternal(
             .collect(Collectors.toMap(ClusterFeature::feature, 
ClusterFeature::version));
 
         ClusterConfig config = ClusterConfig.builder()
-            .setTypes(new HashSet<>(Arrays.asList(types)))
+            .setTypes(new HashSet<>(List.of(types)))

Review Comment:
   ```suggestion
               .setTypes(Set.of(types))
   ```



##########
test-common/test-common-runtime/src/test/java/org/apache/kafka/common/test/KafkaClusterTestKitTest.java:
##########
@@ -105,9 +104,9 @@ public void 
testCreateClusterAndCloseWithMultipleLogDirs(boolean combined) throw
 
             nodes.brokerNodes().forEach((brokerId, node) -> {
                 assertEquals(2, node.logDataDirectories().size());
-                Set<String> expected = new 
HashSet<>(Arrays.asList(String.format("broker_%d_data0", brokerId), 
String.format("broker_%d_data1", brokerId)));
+                Set<String> expected = new 
HashSet<>(List.of(String.format("broker_%d_data0", brokerId), 
String.format("broker_%d_data1", brokerId)));

Review Comment:
   ```suggestion
                   Set<String> expected = 
Set.of(String.format("broker_%d_data0", brokerId), 
String.format("broker_%d_data1", brokerId));
   ```



##########
test-common/test-common-runtime/src/test/java/org/apache/kafka/common/test/KafkaClusterTestKitTest.java:
##########
@@ -105,9 +104,9 @@ public void 
testCreateClusterAndCloseWithMultipleLogDirs(boolean combined) throw
 
             nodes.brokerNodes().forEach((brokerId, node) -> {
                 assertEquals(2, node.logDataDirectories().size());
-                Set<String> expected = new 
HashSet<>(Arrays.asList(String.format("broker_%d_data0", brokerId), 
String.format("broker_%d_data1", brokerId)));
+                Set<String> expected = new 
HashSet<>(List.of(String.format("broker_%d_data0", brokerId), 
String.format("broker_%d_data1", brokerId)));
                 if (nodes.isCombined(node.id())) {
-                    expected = new 
HashSet<>(Arrays.asList(String.format("combined_%d_0", brokerId), 
String.format("combined_%d_1", brokerId)));
+                    expected = new 
HashSet<>(List.of(String.format("combined_%d_0", brokerId), 
String.format("combined_%d_1", brokerId)));

Review Comment:
   ```suggestion
                       expected = Set.of(String.format("combined_%d_0", 
brokerId), String.format("combined_%d_1", brokerId));
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org