chia7712 commented on code in PR #19792:
URL: https://github.com/apache/kafka/pull/19792#discussion_r2104333197
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -8136,10 +8137,14 @@ public Map.Entry<AlterShareGroupOffsetsResponseData,
InitializeShareGroupStatePa
}
});
- initializingTopics.put(topicId, topic.partitions().stream()
-
.map(AlterShareGroupOffsetsRequestData.AlterShareGroupOffsetsRequestPartition::partitionIndex)
- .filter(existingPartitions::contains)
- .collect(Collectors.toSet()));
+ initializingTopics.put(topicId, new InitMapValue(
Review Comment:
The current version is better because `initializingTopics` already contains
complete information (ID and name), and `attachInitValue` would create an
additional map. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
