m1a2st commented on code in PR #19798: URL: https://github.com/apache/kafka/pull/19798#discussion_r2105753702
########## core/src/main/scala/kafka/server/DelayedProduce.scala: ########## @@ -17,20 +17,18 @@ package kafka.server -import java.util.concurrent.{ConcurrentHashMap, TimeUnit} -import java.util.concurrent.locks.Lock import com.typesafe.scalalogging.Logger import com.yammer.metrics.core.Meter import kafka.utils.Logging -import org.apache.kafka.common.{TopicIdPartition, TopicPartition} import org.apache.kafka.common.protocol.Errors import org.apache.kafka.common.requests.ProduceResponse.PartitionResponse +import org.apache.kafka.common.{TopicIdPartition, TopicPartition} import org.apache.kafka.server.metrics.KafkaMetricsGroup import org.apache.kafka.server.purgatory.DelayedOperation +import java.util.concurrent.{ConcurrentHashMap, TimeUnit} import scala.collection._ import scala.jdk.CollectionConverters._ -import scala.jdk.OptionConverters.RichOption Review Comment: Could you remove the `java.util.concurrent.locks.Lock` and `scala.jdk.OptionConverters.RichOption` imports only without changing the order of the other imports? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org