FrankYang0529 commented on code in PR #19761:
URL: https://github.com/apache/kafka/pull/19761#discussion_r2107945239
##########
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java:
##########
@@ -20635,12 +21067,10 @@ barTopicName, new TopicMetadata(barTopicId,
barTopicName, 3)
),
// Remove regex.
List.of(GroupCoordinatorRecordHelpers.newConsumerGroupRegularExpressionTombstone(groupId,
"foo*")),
- // Updated subscription metadata.
-
List.of(GroupCoordinatorRecordHelpers.newConsumerGroupSubscriptionMetadataRecord(groupId,
Map.of(
- barTopicName, new TopicMetadata(barTopicId, barTopicName,
3)
- ))),
// Bumped epoch.
-
List.of(GroupCoordinatorRecordHelpers.newConsumerGroupEpochRecord(groupId, 11,
0))
+
List.of(GroupCoordinatorRecordHelpers.newConsumerGroupEpochRecord(groupId, 11,
computeGroupHash(Map.of(
+ barTopicName, barTopicHash
+ ))))
),
result.records()
Review Comment:
Thanks for the suggestion. I add test to following cases:
* update: testNewRacksDataInMetadataImageTriggersEpochBump
* remove: testRemoveTopicCleanupTopicHash
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
