chia7712 commented on code in PR #19864:
URL: https://github.com/apache/kafka/pull/19864#discussion_r2116440158
##########
clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java:
##########
@@ -1001,7 +1005,9 @@ public void commitSync(Duration timeout) {
* (in which case a {@link
org.apache.kafka.common.errors.TimeoutException} is thrown to the caller).
* <p>
* Note that asynchronous offset commits sent previously with the {@link
#commitAsync(OffsetCommitCallback)}
- * (or similar) are guaranteed to have their callbacks invoked prior to
completion of this method.
+ * (or similar) are guaranteed to have their callbacks invoked prior to
completion of this method,
+ * but only when the consumer is using the consumer group protocol.
+ * This guarantee does not hold when using the classic group protocol.
Review Comment:
`but only when the consumer is using the consumer group protocol.` This says
it all :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
