AndrewJSchofield commented on code in PR #19878:
URL: https://github.com/apache/kafka/pull/19878#discussion_r2121146664


##########
tests/kafkatest/services/verifiable_share_consumer.py:
##########
@@ -108,7 +108,7 @@ class VerifiableShareConsumer(KafkaPathResolverMixin, 
VerifiableClientMixin, Bac
             }
 
     def __init__(self, context, num_nodes, kafka, topic, group_id,
-                 max_messages=-1, acknowledgement_mode="auto", 
offset_reset_strategy="",
+                 max_messages=-1, acknowledgement_mode="auto", 
offset_reset_strategy=None,

Review Comment:
   Couldn't you have removed `offset_reset_strategy` entirely from the 
verifiable share consumer python wrapper?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to