AndrewJSchofield commented on PR #19815: URL: https://github.com/apache/kafka/pull/19815#issuecomment-2931028111
> @dajac @AndrewJSchofield Thanks for the review. I think we only need to optimize the case like `AlterShareGroupOffsetsResponse.java` which tries to use `HashMap` to build the response. We can do enhancement by `mapKey`, so it can use the generated collection directly. I go through all request / response. We probably need to modify `AlterShareGroupOffsetsResponse.json`. If you all agree with it, I can update it in this PR. > > [#18929 (comment)](https://github.com/apache/kafka/pull/18929#discussion_r2091058650) > > cc @chia7712 Sounds good to me. I agree that the most benefit is for accessing the data by key. I'm happy with you updating that response JSON schema. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
